The purpose of this study was to clarify the results of teaching practice to improve pre-service music teachers’ teaching skills in terms of student guidance and musical instruction. The teaching practice was conducted with four schools affiliated with Hiroshima University in Japan. Pre-service teachers received comments on their teaching from students in each class. They also assessed their own teaching behavior and musical teaching skills after a period of teaching practice. In addition, they received evaluations from mentors on these teaching skills and reflected on what was pointed out at the evaluation meeting. Through the analysis of self-assessment scores and description of pre-service teachers’ reflection, the authors found that level of the teaching skills acquired by pre-service teachers depended on school characteristics or the lesson topics that they dealt with. To enhance the effectiveness of teaching practice, it is important to share goals between mentors and pre-service teachers.